Use separate Config type for stream/fold channels#3034
Merged
harendra-kumar merged 1 commit intomasterfrom May 20, 2025
Merged
Conversation
harendra-kumar
force-pushed
the
split-stream-fold-config
branch
from
68871dc to
d3299c9
Compare
harendra-kumar
changed the title
harendra-kumar
force-pushed
the
split-stream-fold-config
branch
from
d3299c9 to
b39cf4c
Compare
Member
|
Shouldn't |
Member
Author
what changes? It is using the Config type from Fold. Which function is to be deprecated? We are still using the same functions except that Fold and stream are using separate definitions. |
Member
|
Oh nvm. I misunderstood. This looks good to me. |
adithyaov
approved these changes
May 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.